Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 4, 2022

Imported from app-tutorial.
Modified to detect APP_NAME from repository name.

Signed-off-by: Côme Chilliet [email protected]

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc added the 3. to review Waiting for reviews label Apr 4, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Apr 4, 2022

Not sure what you put as svg file. Is it mandatory?

@nickvergessen
Copy link
Member

Copy https://phpunit.de/img/phpunit.svg ?

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Copy link
Contributor Author

come-nc commented Apr 4, 2022

Copy https://phpunit.de/img/phpunit.svg ?

done

@nickvergessen
Copy link
Member

For demo see here nextcloud/privacy#755

@ChristophWurst
Copy link
Member

you could also have one config with a matrix of the four databases

@come-nc
Copy link
Contributor Author

come-nc commented Apr 5, 2022

@nickvergessen @ChristophWurst Testing in nextcloud/activity#777 as an example, the tests fail, do you think it comes from the removed php -S localhost:8080 &?

@nickvergessen
Copy link
Member

Seems to be unrelated as moving it up and enabling it doesn't seem to fix it.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 5, 2022

you could also have one config with a matrix of the four databases

Seems much cleaner to have 4 smaller yml files. 🤷

@skjnldsv skjnldsv merged commit 4123407 into master Apr 5, 2022
@skjnldsv skjnldsv deleted the enh/add-phpunit branch April 5, 2022 13:15
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Apr 5, 2022
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 5, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Apr 5, 2022

Looks great!! 🚀

@come-nc
Copy link
Contributor Author

come-nc commented Apr 5, 2022

Looks great!! rocket

But it does not work yet on nextcloud/activity#777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants