Skip to content

lgtm: not self assigning 👍 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Aug 1, 2016
Merged

lgtm: not self assigning 👍 #4

AndyScherzinger merged 1 commit into from
Aug 1, 2016

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 23, 2016

No description provided.

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 23, 2016

👍

1 similar comment
@przybylski
Copy link
Member

przybylski commented Jul 2, 2016

👍

@MariusBluem
Copy link
Member

MariusBluem commented Jul 2, 2016

👎 This will not work. Neither as it is was done here nor with the version I have tried in nextcloud/server 😢 ...we dont know why and how to fix it currently.

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Jul 3, 2016

@Mar1u5 for us it is working except that it does not recognize sometimes the second thumps up.
What is not working for you?

@MariusBluem
Copy link
Member

MariusBluem commented Jul 3, 2016

...the self assigning part is not working @ nextcloud/server. We have tried it several times, but it is still possible 😕 nextcloud/server#238

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jul 3, 2016 •
edited
Loading

@Mar1u5 we experienced several hiccups like @tobiasKaminsky mentioned, sometimes +1s aren't detected, sometimes self approval still works. My guess is that LGTM doesn't work consistently but it is still better than not having the LGTM support at all :)

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jul 3, 2016 •
edited
Loading

Yay, again the LGTM has hiccups...

@AndyScherzinger AndyScherzinger added this to the Nextcloud Android library 1.0.2 milestone Aug 1, 2016
@AndyScherzinger AndyScherzinger merged commit e6068f8 into master Aug 1, 2016
@AndyScherzinger AndyScherzinger deleted the noSelfApproving branch August 1, 2016 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4. to release enhancement

Projects

None yet

Milestone

NC lib 1.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@tobiasKaminsky @AndyScherzinger @przybylski @MariusBluem