Get rid of LGTM self approvals #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add missing spaces
Member
|
👍 |
Member
|
@Mar1u5 Could you try this here? |
Member
Won't work as per documentation it only takes the one from the branch that is targeted. (so master here) |
Member
|
LGTM |
Member
Author
|
We try it in #236 😉 |
Member
Author
|
We try it now with #242 because #236 was based on an older |
Member
|
@Mar1u5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An bug initially introduced by @tobiasKaminsky in nextcloud/android#13 i've took over to the server in #77 and #78 😒
If this works, I will obviously create a backport for
stable9and add this to our other LGTM repos 😉cc @MorrisJobke @LukasReschke