Skip to content

lgtm: not self assigning 👍 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MariusBluem merged 1 commit into from
Jun 13, 2016
Merged

lgtm: not self assigning 👍 #13

MariusBluem merged 1 commit into from
Jun 13, 2016

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 13, 2016

prevent self 👍

@MariusBluem
Copy link
Member

MariusBluem commented Jun 13, 2016

👍

@MariusBluem MariusBluem mentioned this pull request Jun 13, 2016
Merged
@LukasReschke
Copy link
Member

LukasReschke commented Jun 13, 2016

LGTM

@MariusBluem
Copy link
Member

MariusBluem commented Jun 13, 2016

...uhm: why does approvals/lgtm does not report 👍 😱

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 13, 2016

👍

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 13, 2016

@Mar1u5 because now only people in the Maintainer List can do approvals ;)

@MariusBluem MariusBluem merged commit 34c3f0b into master Jun 13, 2016
@MariusBluem MariusBluem deleted the lgtm-noSelf branch June 13, 2016 18:35
@MariusBluem
Copy link
Member

MariusBluem commented Jun 13, 2016

I see 😅 @AndyScherzinger

@MariusBluem MariusBluem mentioned this pull request Jun 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tobiasKaminsky @MariusBluem @LukasReschke @AndyScherzinger