Add activity previews #1838
Closed
Add activity previews #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String sTime = ""; | ||
| for (Object o : activityItems) { | ||
| List<Activity> activityList = (List<Activity>) activityItems.get(0); | ||
| for (Object o : activityList) { |
Member
There was a problem hiding this comment.
erm, wouldn't make sense to then use Activity right away since you casted to a List of Activities already? ;)
Member
Author
There was a problem hiding this comment.
It was a really quick fix to get it working.
But currently I am unsure what the nextcloud/android-library#73 pr is doing at all... ;-)
Member
There was a problem hiding this comment.
We should also find the root cause of #1848 since that reported bug would still happen here and cause a crash of the app...
Member
There was a problem hiding this comment.
Or not, I am not sure at this time of the day... too late at night...
Member
Author
|
Postponed until clarification of library PR. #1848 should be independent of this. |
tobiasKaminsky
added
the
needs info
Member
Author
|
Closing in favor of #3130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate nextcloud/android-library#73