Activity: use image url instead of generating previews by oneself #3130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tobiasKaminsky
force-pushed
the
activityPreview
branch
from
b8af15f to
c620a93
Compare
tobiasKaminsky
added
3. to review
2. developing
and removed
2. developing
3. to review
labels
Member
Author
|
Damn, I totally forgot the backward compatibility :-/ |
tobiasKaminsky
force-pushed
the
activityPreview
branch
4 times, most recently
from
0823cd1 to
181d7f6
Compare
Member
|
@tobiasKaminsky the lib change say compatible with Nc14. Is that what you meant with backwards compatible, because there is still also Nc13 maybe 12? |
Member
Author
|
I am using old thumbnail system on <15 and new on >=15: It depends on activity app version, but I would like to bind it to a NC version, so that we can remove it on NC19 :-) |
tobiasKaminsky
force-pushed
the
activityPreview
branch
from
181d7f6 to
dce0b42
Compare
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Signed-off-by: tobiasKaminsky <[email protected]>
tobiasKaminsky
force-pushed
the
activityPreview
branch
from
dce0b42 to
52f7723
Compare
Collaborator
Lint
FindBugs (new)
FindBugs (master)
|
Member
|
@tobiasKaminsky fancy taking a look? I am on the train right now so I can't :/ EDIT: drone was just using the old lib, though it was changed in branch… |
Member
Author
|
What shall I do? I merged it ~45min before your comment :-) |
Member
|
Nothing all. Good it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs nextcloud/android-library#73 and nextcloud/activity#300
Previously we tried to find a referenced file in our database and then generated a thumbnail out of it.
Now we rely on the server to get a preview url. This way we can have thumbnails for files we never had in our database before.
TODO
Signed-off-by: tobiasKaminsky [email protected]