use path separator constant

[jmue]

Use already defined path separator constant.

[tobiasKaminsky]

Nice!
But there are even more, if you search for "/" in total project.
So…if you want… :-)

[jmue]

Nice!
But there are even more, if you search for "/" in total project.
So…if you want… :-)

Added even more.
But I'm unsure how to deal with slashes within uri context. From my point of view they are not logical part of OCFile.PATH_SEPARATOR constant.

[tobiasKaminsky]

But I'm unsure how to deal with slashes within uri context. From my point of view they are not logical part of OCFile.PATH_SEPARATOR constant.

I would keep them, as you are right that they are not related to OCFile/files at all.

[nextcloud-android-bot]

Codacy

299

Lint

Type	master	PR
Warnings	57	57
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	123
Security Warnings	47
Dodgy code Warnings	132
Total	434

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	80
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	123
Security Warnings	47
Dodgy code Warnings	132
Total	435

[codecov]

Codecov Report

Merging #3915 into master will decrease coverage by <.01%.
The diff coverage is 8.33%.

@@             Coverage Diff             @@
##             master   #3915      +/-   ##
===========================================
- Coverage      6.59%   6.59%   -0.01%     
  Complexity        1       1              
===========================================
  Files           320     320              
  Lines         30823   30816       -7     
  Branches       4397    4394       -3     
===========================================
- Hits           2033    2032       -1     
+ Misses        28494   28487       -7     
- Partials        296     297       +1

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/datamodel/SyncedFolderProvider.java	11.2% <0%> (ø)	0 <0> (ø)	⬇️
...va/org/nextcloud/providers/cursors/RootCursor.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...java/com/owncloud/android/jobs/OfflineSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	11.96% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/ui/trashbin/TrashbinPresenter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...n/java/com/owncloud/android/jobs/FilesSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...android/authentication/AuthenticatorAsyncTask.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ud/android/providers/DocumentsStorageProvider.java	1.07% <0%> (ø)	0 <0> (ø)	⬇️
...roid/ui/activity/ReceiveExternalFilesActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
... and 7 more

[tobiasKaminsky]

Thank you very much!