Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

Bumps gradle from 3.3.2 to 3.4.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Apr 18, 2019
@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.android.tools.build-gradle-3.4.0 branch from 176a8ff to 762fd8c Compare April 18, 2019 05:39
@AndyScherzinger
Copy link
Member

Increases lint likely due to changed lint checks. @tobiasKaminsky can you bump the score for now? ❤️

Bumps gradle from 3.3.2 to 3.4.0.

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.android.tools.build-gradle-3.4.0 branch from 762fd8c to c2730e8 Compare April 18, 2019 07:47
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #3921 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #3921      +/-   ##
===========================================
- Coverage      6.58%   6.53%   -0.06%     
  Complexity        1       1              
===========================================
  Files           320     320              
  Lines         30806   30806              
  Branches       4393    4393              
===========================================
- Hits           2030    2013      -17     
- Misses        28480   28497      +17     
  Partials        296     296
Impacted Files Coverage Δ Complexity Δ
...services/firebase/NCFirebaseInstanceIDService.java 0% <0%> (-87.5%) 0% <0%> (ø)
.../services/firebase/NCFirebaseMessagingService.java 0% <0%> (-7.15%) 0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java 29.86% <0%> (-4.17%) 0% <0%> (ø)
...cloud/android/datamodel/ArbitraryDataProvider.java 11.53% <0%> (-1.29%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (-1.2%) 0% <0%> (ø)
src/main/java/com/owncloud/android/MainApp.java 45.7% <0%> (-0.35%) 0% <0%> (ø)

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #3921 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #3921      +/-   ##
===========================================
+ Coverage      6.58%   6.59%   +<.01%     
  Complexity        1       1              
===========================================
  Files           320     320              
  Lines         30806   30823      +17     
  Branches       4393    4397       +4     
===========================================
+ Hits           2030    2032       +2     
- Misses        28480   28495      +15     
  Partials        296     296
Impacted Files Coverage Δ Complexity Δ
...in/java/com/owncloud/android/datamodel/OCFile.java 59.54% <0%> (-0.28%) 0% <0%> (ø)
.../android/authentication/AuthenticatorActivity.java 1.87% <0%> (-0.02%) 0% <0%> (ø)
...owncloud/android/ui/components/CustomEditText.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...java/com/owncloud/android/jobs/OfflineSyncJob.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ncloud/android/datamodel/SyncedFolderProvider.java 11.2% <0%> (ø) 0% <0%> (ø) ⬇️
...va/com/owncloud/android/utils/FilesSyncHelper.java 26.78% <0%> (ø) 0% <0%> (ø) ⬇️
...ncloud/android/ui/adapter/TrashbinListAdapter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
src/main/java/com/owncloud/android/MainApp.java 46.04% <0%> (ø) 0% <0%> (ø) ⬇️
...wncloud/android/ui/trashbin/TrashbinPresenter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...xtcloud/client/account/UserAccountManagerImpl.java 11.66% <0%> (ø) 0% <0%> (ø) ⬇️
... and 19 more

@nextcloud-android-bot
Copy link
Collaborator

Codacy

425

Lint

TypemasterPR
Warnings5758
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings15
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings123
Security Warnings47
Dodgy code Warnings132
Total434

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings15
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings123
Security Warnings47
Dodgy code Warnings132
Total434

@tobiasKaminsky tobiasKaminsky merged commit 2379b49 into master Apr 18, 2019
@tobiasKaminsky tobiasKaminsky deleted the dependabot/gradle/com.android.tools.build-gradle-3.4.0 branch April 18, 2019 07:57
@tobiasKaminsky
Copy link
Member

I fixed 4 issues, thus I only had to increase by one :-)

nextcloud-android-bot pushed a commit that referenced this pull request May 2, 2019
71f3370 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
0f50088 Merge pull request #3916 from jmue/cleanup/string_compare
7bb07a0 Update wording for store text (#3903)
4c72f3f Merge pull request #3923 from nextcloud/editOnShareLink
81ed32f allow edit on link share on a file
7d01ff7 - fix IT tests - re-organized build.gradle a bit
a9afff7 Merge pull request #3929 from nextcloud/dependabot/gradle/org.powermock-powermock-core-2.0.2
71c6d99 bump all other powermock parts to 2.0.2
0421d26 Bump powermock-core from 2.0.0 to 2.0.2
1d28d1b Update with new wording from frontpage
de3d3de Merge pull request #3924 from nextcloud/warnOnStable
69dd243 warn for wrong library branch on stable
2379b49 Merge pull request #3921 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.4.0
c2730e8 Bump gradle from 3.3.2 to 3.4.0
b69169f unify empty string compare
8bb654b fix test & review comments
d8b9d10 unify empty string compare
2f23a30 remove unused variable (#3920)
92df32e Merge pull request #3918 from nextcloud/codacyCleanup
091c003 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
15ec487 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
da3c497 Merge commit '334155e707975e740a0a13b33d9b7bbedf40e9bc'
b22f517 Merge pull request #3915 from jmue/cleanup/ocfile
c7c6a98 use constant
e6604c8 use constant
caa2a91 Merge pull request #3912 from nextcloud/libraryUsage
334155e some cleanups
28f80cd Merge pull request #3907 from nextcloud/ezaquarii/initialize-main-app-context-before-content-providers-start
2afb934 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
8be1157 Merge pull request #3899 from jmue/cleanup/uriutils
52020a9 direct usage of library project
4062d40 Merge pull request #3908 from nextcloud/missingInjectable
2a08cb4 Initialize global context before MainApp.onCreate()
f02f482 Missing Injectable lead to half-stored account
02cbafe Merge pull request #3765 from nextcloud/showSharees
dc7a2c0 show sharees
03e04e5 Merge pull request #3889 from nextcloud/checkUserId
d65e94b Update wording for store text
585a3d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
533debf - removed useNextcloudUserAgent -> we now use this everytime - removed any oAuth and saml stuff, as we rely on weblogin flow
d544fa5 Merge pull request #3897 from nextcloud/ezaquarii/move-current-account-getter-to-user-account-manager
5b4ffba Merge pull request #3900 from nextcloud/codacyOnMaster
2757244 remove unused code
428a8bb show codacy count only on master
6b44074 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
c62e89b Merge commit '442394f949ff2de86bcccae172d2e9d997ab2ef8'
442394f Migrate current account getter from AccountUtils to UserAccountManager
182b65e daily dev 20190414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants