Skip to content

Conversation

@BerengarWLehr
Copy link
Contributor

Following up on the discussion #587 I'd suggest that the prevention of using https for the manual-install Daemon should be removed as it doesn't seem to have any inherit reason.

There are indeed real world use cases in which manual-install is an equal strategy for deploying containers for ExApps. There are sophisticated ways to let NC run the ExAppContainer but sometimes running it manually is just another way to reach Rome.

PS: This is the 2nd corrected version of #591 m(

@oleksandr-nc
Copy link
Contributor

Hello. What did corrected in this version? I just do not get why you had close two other PR's..

@BerengarWLehr
Copy link
Contributor Author

BerengarWLehr commented Jun 6, 2025

@oleksandr-nc in the first PR I deleted the wrong lines (sloppy me deleted the if clause three lines above) in the 2nd I forgot to sign it off and couldn't for the love of god figure out how to repair this.

@oleksandr-nc oleksandr-nc merged commit ca10e12 into nextcloud:main Jun 10, 2025
34 checks passed
@oleksandr-nc
Copy link
Contributor

Thanks for the PR.
But I am not sure that we can backport this without adjusting documentation and testing that it works.

@BerengarWLehr if you can test this on Nextcloud 32 (to which current main branch belongs) and say that if it works for your case will be very nice. Of course if you want. After that we can accept PR to the documentation and backport this to Nextcloud 31 if needed.

@BerengarWLehr
Copy link
Contributor Author

Hy @oleksandr-nc,
sorry for the delay due to the summer break. I'm not quite sure if you did a type-o or if I missunderstood you. I tested the change in our environment and there were zero problems switching to https/tls in version 31.0.7
I did not test with version 32 but was confused as you wrote I should test with v32 for a backport to v31?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants