Skip to content

Remove https prevention for manual-install #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 2 commits into from
Jun 10, 2025
Merged

Remove https prevention for manual-install #593

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25ac37
Remove https prevention for manual-install
BerengarWLehr Jun 5, 2025
85c77fb
Merge branch 'main' into main
BerengarWLehr Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove https prevention for manual-install 
Signed-off-by: Berengar W. Lehr <[email protected]>
  • Loading branch information
@BerengarWLehr
BerengarWLehr committed Jun 5, 2025
commit f25ac37f35a6ca971f7e1297873b25165404b818
4 changes: 0 additions & 4 deletions lib/Command/Daemon/RegisterDaemon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$output->writeln('Value error: The protocol must be `http` or `https`.');
return 1;
}
if ($acceptsDeployId === 'manual-install' && $protocol !== 'http') {
$output->writeln('Value error: Manual-install daemon supports only `http` protocol.');
return 1;
}
if ($isHarp && !$input->getOption('harp_shared_key')) {
$output->writeln('Value error: HaRP enabled daemon requires `harp_shared_key` option.');
return 1;
Expand Down