Upgrade phpunit testing suite #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
feat/phpunit
branch
from
78c1ce8 to
8f85c77
Compare
Member
Author
|
/rebase |
Signed-off-by: John Molakvoæ <[email protected]>
nextcloud-command
force-pushed
the
feat/phpunit
branch
from
8f85c77 to
fff5fe6
Compare
Member
|
Why didn't the oci tests catch the problem with a notnull column having an empty string as default value? |
julien-nc
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need that much tests 😅
This simplify it a bit and use the official templates