Fix installing on Oracle

[nickvergessen]

Empty strings are stored as null in Oracle,
so a column with NotNull can not have an empty string as default

Signed-off-by: Joas Schilling [email protected]

[nickvergessen]

/backport to stable19

[nickvergessen]

/backport to stable18

[nickvergessen]

I will write a method into the oracle checker to error on this.

[ChristophWurst]

🙈

[nickvergessen]

Pushed an addition to the checker.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32748: failure

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 2 failures:

1) Test\Files\Cache\PropagatorTest::testSizePropagation
Failed asserting that 3 matches expected 13.

/drone/src/tests/lib/Files/Cache/PropagatorTest.php:80

2) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearCommentReadMarks
Failed asserting that actual size 0 matches expected size 1.

/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:252

mysql8.0-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\CacheTest::testGetById
null does not match expected type "array".

/drone/src/tests/lib/Files/Cache/CacheTest.php:495