Migrate owncloud versions and add validation for more elements #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2016 13:50
…elds prevented apps from being uploaded
| <xs:element name="lib" type="min-max-version" minOccurs="0" | ||
| maxOccurs="unbounded"/> | ||
| <xs:element name="owncloud" type="owncloud" minOccurs="1" | ||
| <xs:element name="nextcloud" type="nextcloud" minOccurs="1" |
Member
Author
There was a problem hiding this comment.
Minimum version is required (also in core afaik)
provided owncloud tags are migrated to nextcloud tags, that way there will always be a nextcloud tag if set properly
…f standalone, shipped or default_enable elements are present
Member
Author
|
I've also added the following things:
|
…ninstall elements, fail validation if remote or public is present
Member
Author
|
More validation, see updated first post |
BernhardPosselt
changed the title
Member
Author
|
👍 from IRC |
joshtrichards
added a commit
to nextcloud/server
that referenced
this pull request
Aug 18, 2025
Endpoints are all hardcoded since 7bdde98 and were formally deprecated within info.xml in nextcloud/appstore#156. Follow-up PR will clean-up references elsewhere. Signed-off-by: Josh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works in the following way:
If no tag exists the versions will be taken from and following will be done:
I hope that's enough and we dont need to consider further exceptions
Furthermore:
@nickvergessen @janibonnevier @adsworth @LukasReschke @MorrisJobke please review