add schema validation for background-jobs and repair-steps and fail i…

…f standalone, shipped or default_enable elements are present

nextcloudappstore/core/api/v1/release/pre-info.xslt

@@ -35,6 +35,11 @@
             <xsl:apply-templates select="dependencies"/>
             <xsl:copy-of select="background-jobs"/>
             <xsl:apply-templates select="repair-steps"/>
+
+            <!-- copy invalid elements to fail if they are present -->
+            <xsl:copy-of select="standalone"/>
+            <xsl:copy-of select="default_enable"/>
+            <xsl:copy-of select="shipped"/>
         </info>
     </xsl:template>
 

nextcloudappstore/core/api/v1/tests/data/infoxmls/invalid-elements.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0"?>
+<info xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../appmetadata/info.xsd">
+    <id>news</id>
+    <name>News</name>
+    <summary>An RSS/Atom feed reader</summary>
+    <description>An RSS/Atom feed reader</description>
+    <version>8.8.2</version>
+    <licence>agpl</licence>
+    <author>Bernhard Posselt</author>
+    <category>multimedia</category>
+    <dependencies>
+        <owncloud min-version="9.0"/>
+    </dependencies>
+    <standalone/>
+    <default_enable/>
+    <shipped>true</shipped>
+</info>

nextcloudappstore/core/api/v1/tests/test_parser.py

@@ -58,6 +58,13 @@ def test_parse_repair_jobs(self):
                            self.config.pre_info_xslt,
                            self.config.info_xslt)
 
+    def test_parse_invalid_elements(self):
+        xml = self._get_test_xml('data/infoxmls/invalid-elements.xml')
+        with (self.assertRaises(InvalidAppMetadataXmlException)):
+            parse_app_metadata(xml, self.config.info_schema,
+                               self.config.pre_info_xslt,
+                               self.config.info_xslt)
+
     def test_parse_minimal_transform(self):
         xml = self._get_test_xml('data/infoxmls/transform.xml')
         result = parse_app_metadata(xml, self.config.info_schema,