Fix: Inconsistencies due to parameters in description property #3924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
approved these changes
Feb 1, 2022
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix.
Tested with multiple parameters and works fine.
Codecov Report
@@ Coverage Diff @@
## main #3924 +/- ##
=========================================
Coverage 29.42% 29.42%
Complexity 322 322
=========================================
Files 221 221
Lines 7578 7578
Branches 1001 1000 -1
=========================================
Hits 2230 2230
Misses 5348 5348
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
@max65482 Could you be so kind to rebase once more to current main? I fixed the broken PHP tests there. |
Signed-off-by: Maximilian Martin <[email protected]>
Signed-off-by: Maximilian Martin <[email protected]>
max65482
force-pushed
the
clear_description_parameters
branch
from
b125fd8 to
4086576
Compare
Contributor
Author
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #3918. In this old PR only the ALTREP parameter is cleared upon modification of the description property. It therefore solves #3863. However, also all other possible parameters may cause inconsistencies. This PR deletes all parameters of the description property upon modification.