Fix: Inconsistencies due to Apple's additional location property #3930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Martin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3930 +/- ##
============================================
- Coverage 29.42% 29.42% -0.01%
Complexity 322 322
============================================
Files 221 221
Lines 7578 7579 +1
Branches 1001 1001
============================================
Hits 2230 2230
- Misses 5348 5349 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tcitworld
approved these changes
Feb 4, 2022
Member
|
/backport to stable3.0 |
backportbot-nextcloud
bot
added
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3924, this PR fixes an inconsistency issue. This time it is about the additional location information that Apple applications store in the
X-APPLE-STRUCTURED-LOCATIONproperty. This is a supplement to the regularLOCATIONproperty. It includes coordinates and a custom map reference. Upon change ofLOCATIONin a non-Apple application,X-APPLE-STRUCTURED-LOCATIONbecomes invalid. This PR solves this inconsistency by removing theX-APPLE-STRUCTURED-LOCATIONproperty upon change of the location.Discussion can be found in #3905.