Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented May 24, 2025

@st3iny st3iny self-assigned this May 24, 2025
@st3iny st3iny added 2. developing Work in progress enhancement New feature request Feature: Sharing labels May 24, 2025
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

❌ Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.84%. Comparing base (9a754e6) to head (d08a9ba).
⚠️ Report is 117 commits behind head on main.

Files with missing lines Patch % Lines
.../AppNavigation/EditCalendarModal/SharingSearch.vue 0.00% 15 Missing ⚠️
...ents/AppNavigation/EditCalendarModal/ShareItem.vue 0.00% 5 Missing ⚠️
src/store/calendars.js 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9a754e6) and HEAD (d08a9ba). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9a754e6) HEAD (d08a9ba)
php 4 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6998      +/-   ##
============================================
- Coverage     22.98%   14.84%   -8.14%     
============================================
  Files           254      212      -42     
  Lines         12589    10299    -2290     
  Branches       2478     2484       +6     
============================================
- Hits           2893     1529    -1364     
+ Misses         9346     8420     -926     
  Partials        350      350              
Flag Coverage Δ
javascript 14.84% <16.00%> (+<0.01%) ⬆️
php ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st3iny st3iny force-pushed the feat/federated-calendar-sharing branch from 35a7c52 to 9c5cda6 Compare July 29, 2025 11:53
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 12, 2025
@st3iny st3iny marked this pull request as ready for review August 12, 2025 12:10
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the feat/federated-calendar-sharing branch from 79384d1 to d08a9ba Compare August 27, 2025 15:20
Copy link
Member Author

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squashed all commits and added a simple feature gate to prevent an additional request for remote sharees.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2025
@st3iny st3iny enabled auto-merge August 27, 2025 15:25
@st3iny st3iny merged commit 5067285 into main Aug 27, 2025
49 of 51 checks passed
@st3iny st3iny deleted the feat/federated-calendar-sharing branch August 27, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request Feature: Sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants