Fix public layout rendering on Nextcloud 14 #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
skjnldsv
approved these changes
Aug 4, 2018
tcitworld
approved these changes
Aug 7, 2018
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Tested and works like a charm.
Member
|
nextcloud/server#10530 is in |
Member
Author
|
@tcitworld @georgehrke Anything blocking here? |
Member
|
Not as far as i can tell. Will give this a review and merge tonight |
georgehrke
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the public page layout for Nextcloud 14. Before this PR calendar was using public instead of base as layout value, which isn't equal with NC14 anymore.
I didn't move it to the newly introduced PublicTemplateResponse, since calendar still supports versions below 14.
Once 14 is a minimal requirement, we should move the public page with header to the new response.
Requires nextcloud/server#10530