Fix issues when using the public layout without a PublicTemplateResponse #10530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
skjnldsv
approved these changes
Aug 3, 2018
juliusknorr
added
bug
3. to review
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/10528/public-template
branch
from
dba0266 to
4f2013b
Compare
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10528
Remove unused parameter access:
Allow using the public layout in a regular TemplateResponse
Call to a member function getHeaderTitle() on null /core/templates/layout.public.php@84c46dd#L38 (blame)
This still needs a fix for calendar, which is using 'public' instead of 'base' the public calendar embedding, see: nextcloud/calendar#882