feature: send email to internal users of circles when shared with circle #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yemkareems <[email protected]>
Signed-off-by: yemkareems <[email protected]>
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Isn't this kind of logic supposed to be implemented through IShareProviderWithNotification?
Signed-off-by: yemkareems <[email protected]>
Contributor
Author
Refactored service to provider |
provokateurin
requested changes
Jun 30, 2025
…WithNotification and set share sendmail to true for circle share in both share and wrapper objects. Send public share link in email. Rename provider to helper Signed-off-by: yemkareems <[email protected]>
…efactor tests Signed-off-by: yemkareems <[email protected]>
Signed-off-by: yemkareems <[email protected]>
provokateurin
requested changes
Jul 8, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Woops I forgot to submit my review
Signed-off-by: yemkareems <[email protected]>
provokateurin
requested changes
Jul 14, 2025
…dition checked once, sendShareNotification type hinting done, sendUserShareMail passing only the share and arguments type hinted, tests refactored Signed-off-by: yemkareems <[email protected]>
…b.com:nextcloud/circles into feature/notify-internal-users-on-circle-share
Signed-off-by: yemkareems <[email protected]>
provokateurin
previously requested changes
Jul 28, 2025
… query user if not required, sendUserShareMail adjusted, dont send email to initiator email condition added and test refactored accordingly Signed-off-by: yemkareems <[email protected]>
…ding methods to send mail service Signed-off-by: yemkareems <[email protected]>
Signed-off-by: yemkareems <[email protected]>
…ed, iShare got from wrappedShare object for sendUserShareMail Signed-off-by: yemkareems <[email protected]>
ArtificialOwl
approved these changes
Aug 12, 2025
Member
|
better approach, thanks for the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: send email to internal users of circles when shared with circle