-
Notifications
You must be signed in to change notification settings - Fork 56
feature: send email to internal users of circles when shared with circle #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yemkareems
merged 17 commits into
master
from
feature/notify-internal-users-on-circle-share
Aug 12, 2025
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b7afadb
feature: send email to internal users of circles when shared with circle
yemkareems 80d58ff
fix: add FileCopyrightText and License-Identifier
yemkareems 222e3d2
fix: refactored service to mail provider and tests adjusted accordingly
yemkareems a10022d
fix: refactor ShareByCircleProvider class to implement IShareProvider…
yemkareems e50f772
fix: move helper functions to provider, remove the helper class and r…
yemkareems 0722d76
fix: composer run cs fix
yemkareems 81e87c0
fix: removed the check sharing.enable_share_mail as it is already done
yemkareems 7d2a2a5
fix: removed the DefaultShareProvider dependency for psalm
yemkareems 787bcb4
Merge branch 'master' into feature/notify-internal-users-on-circle-share
yemkareems bc31bc1
fix: removed comment, corrected text, used user type constant, if con…
yemkareems 05fb5ae
Merge branch 'feature/notify-internal-users-on-circle-share' of githu…
yemkareems 23db5ad
Merge branch 'master' into feature/notify-internal-users-on-circle-share
yemkareems 82acf7c
fix: note was not getting sent in email
yemkareems 4ad4380
fix: initiator moved outside the loop, member check refactored to not…
yemkareems bb52de4
fix: moved sending email to ShareCreatedSendMail and removed mail sen…
yemkareems a9a459c
fix: cs fix
yemkareems c5828fc
fix: user type added to getInheritedMembers, member isLocal check add…
yemkareems File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.