Skip to content

Fix CI and update github actions #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-nextcloud merged 12 commits into from
Mar 26, 2025
Merged

Fix CI and update github actions #1685

max-nextcloud merged 12 commits into from
Mar 26, 2025

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 17, 2025 •
edited by max-nextcloud
Loading

  • Adapting nextcloud/text@64d9887 to make cypress pass again
  • Update action templates
  • Pin actions to hashes
  • Fix psalm

@juliusknorr juliusknorr changed the title fix(ci): cache CYPRESS install in action path Otherwise unpacking the tar file failed on github runners if the cache was created by garm runners and the binary could not be found on garm runners if the cache was created by github runners. Cache proper cypress path Mar 17, 2025
@juliusknorr juliusknorr changed the title Cache proper cypress path Fix CI and update github actions Mar 18, 2025
@max-nextcloud max-nextcloud self-assigned this Mar 18, 2025
@max-nextcloud max-nextcloud force-pushed the ci/cypress-cache branch 2 times, most recently from 9d36da2 to da53483 Compare March 19, 2025 09:42
@max-nextcloud max-nextcloud mentioned this pull request Mar 25, 2025
Closed
7 tasks
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Mar 26, 2025 •
edited
Loading

Cypress sharing tests are failing on stable27 with 500 responses from the server.

"Declaration of OCA\\Collectives\\Controller\\PublicStartController::getPasswordHash(): ?string must be compatible with OCP\\AppFramework\\PublicShareController::getPasswordHash(): string at /home/runner/work/collectives/collectives/apps/collectives/lib/Controller/PublicStartController.php#57"

This has been changed in Nextcloud 29: nextcloud/server#32400

The change in collectives happened in 840d315 - removed that from this PR. We may need to ignore the psalm errors.

juliusknorr and others added 4 commits March 26, 2025 10:51
@juliusknorr @max-nextcloud
fix(ci): cache CYPRESS install in action path
6955060 
Otherwise unpacking the tar file failed on github runners
if the cache was created by garm runners
and the binary could not be found on garm runners
if the cache was created by github runners.

Co-authored-by: Max <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
@juliusknorr @max-nextcloud
chore: Bump github actions from templates
d5c3410 
Signed-off-by: Julius Knorr <[email protected]>
@juliusknorr @max-nextcloud
chore: Pin github actions
c301631 
Signed-off-by: Julius Knorr <[email protected]>
@juliusknorr @max-nextcloud
chore: Set minimum php version for psalm
2175638 
Signed-off-by: Julius Knorr <[email protected]>
@max-nextcloud max-nextcloud merged commit 7f5d29a into main Mar 26, 2025
55 of 58 checks passed
@max-nextcloud max-nextcloud deleted the ci/cypress-cache branch March 26, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees

@max-nextcloud max-nextcloud

Labels

3. to review tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @max-nextcloud