-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Public dav endpoint v2 #32400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public dav endpoint v2 #32400
Conversation
e162aaa to
6233f4e
Compare
6233f4e to
a991665
Compare
a991665 to
3caa9cb
Compare
|
@skjnldsv what happens if you still send basic auth for "https://dev.domain.com/public.php/dav/files/Y9Hc4SPqg564gid" ? will it then try to look for a folder "Y9Hc4SPqg564gid" inside the share ? just to double check that there is no conflict/confusion happening between both approaches |
It will ignore the username. |
736b9ef to
2e3ae15
Compare
46a3e97 to
65483de
Compare
5f9531e to
ac204a7
Compare
ac204a7 to
8773fdf
Compare
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit too much legacy calls and new to my liking, but otherwise seems sane.
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI is good (no breaking changes because it only fixes things that were wrong before).
8773fdf to
d44cc38
Compare
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
d44cc38 to
54df3e2
Compare
Signed-off-by: John Molakvoæ <[email protected]>
54df3e2 to
9e4c9b9
Compare
| </activity> | ||
|
|
||
| <public> | ||
| <webdav>appinfo/v1/publicwebdav.php</webdav> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question to help me understand, the file still exists and public.php/webdav also still prints:
This is the WebDAV interface. It can only be accessed by WebDAV clients such as the Nextcloud desktop sync client.
But where is it registered now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, hardcoded in public.php now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly as how remote.php is doing it :)
I tried to get them closer together now
Fix #19700
Implements a new v2 endpoint which also allows GET
Access a file directly
If password-protected
$ curl -k -u 'anonymous:password' https://dev.domain.com/public.php/dav/files/Y9Hc4SPqg564gid@nextcloud/server-backend any thoughts?