Fix/public viewer #1903
Merged
Fix/public viewer #1903
+47
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
fix/public_viewer
branch
3 times, most recently
from
6312dcf to
99464d2
Compare
mejo-
approved these changes
Jul 26, 2025
max-nextcloud
commented
Jul 26, 2025
max-nextcloud
force-pushed
the
fix/public_viewer
branch
from
b13f3cf to
a025279
Compare
max-nextcloud
commented
Jul 26, 2025
max-nextcloud
force-pushed
the
fix/public_viewer
branch
from
a025279 to
cac1832
Compare
Richdocuments listens on this event to inject its viewer registration. Required to be able to open documents in richdocuments in a public share. Signed-off-by: Jonas <[email protected]>
Try to give correct path depending on whether we're in a public share or not. Signed-off-by: Jonas <[email protected]>
The viewers webdav client is initialized before the vue app is mounted. So we need to provide the inputs before the app is mounted already. Signed-off-by: Max <[email protected]>
When opening an attachment with rich documents from a public collective share a name entry will be shown above the viewer. Keep the viewer z-index to make sure the name entry is visible. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
This way they can be opened within the share. Signed-off-by: Max <[email protected]> Signed-off-by: Jonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Resolves:
(together with fix(share): use relative path in share as davPath for attachments text#7477)
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)