fix(share): use relative path in share as davPath for attachments

[max-nextcloud]

Allow opening attachments in public collective shares
as well as in folder descriptions of public shares.

[max-nextcloud]

I tested this in collectives and in shared folders with a folder description. However I don't know if I am missing some corner cases. All in all the approach seems sound though.

[mejo-]

Thanks for tackling this ❤️

Does this also work with subpage shares in Collectives? I can imagine it does, as internalPath might be relative to the share root? 🤔

[max-nextcloud]

Does this also work with subpage shares in Collectives? I can imagine it does, as internalPath might be relative to the share root? 🤔

Sadly not.... it's relative to the collective root. But maybe we can also resolve it relatively to the share root.

[max-nextcloud]

@mejo- I think I got it now. Could you double check the getShareFolder function?
It's a bit unfortunate to repeat all this code from the getTextFilePublic function. I tried to refactor it with a function that returns both the file and the folder as a list{File, Folder | null} - but I never managed to make psalm happy and it also introduces a fair bit of complexity.

[mejo-]

Nice, great that you found a generic solution that works for all kinds of public file shares ❤️

I didn't test myself, but the code looks sensible to me.

[max-nextcloud]

/backport to stable31

[max-nextcloud]

/backport to stable30

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.65%. Comparing base (aff1125) to head (8b04564).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7477   +/-   ##
=======================================
  Coverage   59.65%   59.65%           
=======================================
  Files         495      495           
  Lines       37866    37866           
  Branches     1090     1090           
=======================================
  Hits        22589    22589           
  Misses      15170    15170           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.