-
Notifications
You must be signed in to change notification settings - Fork 28
Fix new collective name input elements
#551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
new collective name input elements
7eafb3d to
8f534e6
Compare
Passing run #329 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
8f534e6 to
f8118dd
Compare
|
Wow, thanks a lot @susnux. I started work on completely replacing the new collective form with a modal though. Did you see that? #504 I guess that superseedes your PR, no? It's still work in progress but if you fancy a review, that'd be highly appreciated nevertheless. I intend to finish and merge it this week (before next Collectives release). |
|
I'd suggest to still merge this. It fixes ui bugs. If the ui is replaced even before the next release so be it. Maybe the modal takes longer than expected, maybe we want to use this input again later on. Even if not - i don't see any downside to merging this. But maybe I am missing something, @mejo- |
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some first testing, I identified the following issues.
0a29dd6 to
d27eed2
Compare
…d of custom input This resolves some styling issues, like hovering the submit input does not set the border on the text input or mismatching borders. Moreover the `NcMultiselect` is deprecated and should be replaced with the `NcSelect`. Signed-off-by: Ferdinand Thiessen <[email protected]>
d27eed2 to
da90d3a
Compare
|
Thanks a lot @susnux ❤️ |
📝 Summary
This resolves some styling issues, like hovering the submit input does not set the border on the text input or mismatching borders. Moreover the
NcMultiselectis deprecated and should be replaced with theNcSelect.🖼️ Screenshots
Please note that the missing primary color border on hover will be fixed with the next vue components update (see nextcloud-libraries/nextcloud-vue#3701 )
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)