Skip to content

Conversation

@leftybournes
Copy link
Contributor

Depends on: nextcloud/guests#1371

Allow users to invite guests directly through the teams dialog.

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.86%. Comparing base (145f9af) to head (0d9d1e1).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
src/components/EntityPicker/EntityPicker.vue 0.00% 9 Missing ⚠️
src/components/MemberList/MemberList.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               main   #4606      +/-   ##
===========================================
- Coverage     10.56%   9.86%   -0.70%     
  Complexity      265     265              
===========================================
  Files           123     124       +1     
  Lines          5767    6173     +406     
  Branches       1262    1423     +161     
===========================================
  Hits            609     609              
- Misses         5035    5441     +406     
  Partials        123     123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leftybournes leftybournes force-pushed the leftybournes/feat/guest_creation_simplification branch from 9f62da6 to 4da8cb0 Compare August 11, 2025 08:43
@leftybournes leftybournes marked this pull request as ready for review August 11, 2025 09:08
@leftybournes leftybournes added enhancement New feature or request 3. to review Waiting for reviews feature: teams ex circles labels Aug 11, 2025
@GVodyanov
Copy link
Contributor

Hello! Thanks a lot for your PR

@GVodyanov
Copy link
Contributor

I tried making it work, but I don't have any experience with the Guest app. I see that OCA.Guests is undefined, even though I can see the guests in the invitation list and inviting from files works. I'm assuming this has to do with an issue from my configuration and not the code though, so if you could give advice on how to make this run it would be appreciated. Thanks!

@leftybournes leftybournes force-pushed the leftybournes/feat/guest_creation_simplification branch from 4da8cb0 to 57d60a2 Compare August 12, 2025 10:29
@leftybournes
Copy link
Contributor Author

This is part of a collection of pull requests that I opened for the guest creation feature. You will need changes from nextcloud/guests#1371 in the guests app for the changes here to work.

@leftybournes leftybournes requested a review from GVodyanov August 18, 2025 06:41
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing that! Tested and works

@leftybournes leftybournes force-pushed the leftybournes/feat/guest_creation_simplification branch from 57d60a2 to 0d9d1e1 Compare August 18, 2025 14:14
@leftybournes leftybournes merged commit 0af386b into main Aug 18, 2025
42 of 44 checks passed
@leftybournes leftybournes deleted the leftybournes/feat/guest_creation_simplification branch August 18, 2025 14:35
@welcome
Copy link

welcome bot commented Aug 18, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: teams ex circles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants