-
Notifications
You must be signed in to change notification settings - Fork 197
feat: create and add guests to teams #4606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create and add guests to teams #4606
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4606 +/- ##
===========================================
- Coverage 10.56% 9.86% -0.70%
Complexity 265 265
===========================================
Files 123 124 +1
Lines 5767 6173 +406
Branches 1262 1423 +161
===========================================
Hits 609 609
- Misses 5035 5441 +406
Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9f62da6 to
4da8cb0
Compare
|
Hello! Thanks a lot for your PR |
|
I tried making it work, but I don't have any experience with the Guest app. I see that |
4da8cb0 to
57d60a2
Compare
|
This is part of a collection of pull requests that I opened for the guest creation feature. You will need changes from nextcloud/guests#1371 in the guests app for the changes here to work. |
GVodyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing that! Tested and works
Signed-off-by: Kent Delante <[email protected]>
57d60a2 to
0d9d1e1
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Depends on: nextcloud/guests#1371
Allow users to invite guests directly through the teams dialog.
Before:

After:
