feat: provide the guest form to allow guest creation anywhere #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftybournes
commented
Aug 8, 2025
leftybournes
force-pushed
the
leftybournes/feat/guest_creation_simplification
branch
5 times, most recently
from
256658a to
1c121eb
Compare
3 tasks
susnux
reviewed
Aug 8, 2025
leftybournes
force-pushed
the
leftybournes/feat/guest_creation_simplification
branch
4 times, most recently
from
a30daae to
67aff22
Compare
skjnldsv
reviewed
Aug 12, 2025
|
|
||
| import Vue from 'vue' | ||
|
|
||
| import GuestForm from './views/GuestForm.vue' |
Member
There was a problem hiding this comment.
Could we make it async import ?
Can be a followup :)
Member
|
I have a lot of errors when typiing something on the modal, is it just me ? I do not think this is related to this PR though |
skjnldsv
approved these changes
Aug 12, 2025
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Works for me. Only missing part is a showSuccess toast when the account is created
susnux
approved these changes
Aug 13, 2025
leftybournes
force-pushed
the
leftybournes/feat/guest_creation_simplification
branch
from
67aff22 to
28d9c58
Compare
Signed-off-by: Kent Delante <[email protected]>
leftybournes
force-pushed
the
leftybournes/feat/guest_creation_simplification
branch
from
28d9c58 to
0c42d5c
Compare
leftybournes
deleted the
leftybournes/feat/guest_creation_simplification
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1313
Make the guest form dialog available to other apps in order to create guests by calling
OCA.Guests.openGuestDialog. When the guest account is created, the dialog emits an event with the guest's information and can be used in the other app's context.This also sends different emails based on whether the guest was created with or without a share.