Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 24, 2025

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 25, 2025

English source lib/l10n/en_GB.json contains unicode single quote character, that should be replaced by normal single quotes
---
"Your current IP address doesn’t allow you to perform admin actions"

English source lib/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
"Mac OS X is not supported and %s will not work properly on this platform. Use it at your own risk! "

English source apps/encryption/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
" If you don't remember your old password you can ask your administrator to recover your files."

English source apps/files/l10n/en_GB.json contains unicode single quote character, that should be replaced by normal single quotes
---
"You don’t have permission to upload or create files here"
"You don’t have permission to upload or create files here."

English source apps/files/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
"\nYou created an encrypted file in {file}"
" \"remote account\""
"\"{displayName}\" failed on some elements "
"Moved by {user} "
"You created {file}\n"

English source apps/settings/l10n/en_GB.json contains unicode single quote character, that should be replaced by normal single quotes
---
"Admin IP filtering isn’t applied."

English source apps/settings/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
"Detected some missing optional indices. Occasionally new indices are added (by Nextcloud or installed applications) to improve database performance. Adding indices can sometimes take awhile and temporarily hurt performance so this is not done automatically during upgrades. Once the indices are added, queries to those tables should be faster. Use the command `occ db:add-missing-indices` to add them. "

English source apps/sharebymail/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
"%1$s shared %2$s with you.\nYou should have already received a separate mail with a link to access it.\n"
"%1$s shared »%2$s« with you.\nYou should have already received a separate mail with a link to access it.\n"

English source apps/systemtags/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
"System tag creation is now ${isRestricted ? "

English source apps/user_ldap/l10n/en_GB.json contains leading or trailing white spaces, tabs or new lines
---
" Could not set configuration %s"
"Password change rejected. Hint: "

@nickvergessen
Copy link
Member Author

  • Check for ${ which indicates JS variable usage?

@nickvergessen nickvergessen changed the title fix(translation): Notify on broken German translations fix(translation): Notify on broken translations Feb 25, 2025
@nickvergessen
Copy link
Member Author

Server source fixing in nextcloud/server#51049

@rakekniven
Copy link
Member

@nickvergessen Could you merge it and we create another issue for remaining open tasks?

@nickvergessen
Copy link
Member Author

first I need to run the check again, to make sure server passes this now.

@nickvergessen
Copy link
Member Author

Server finally passes, so merging for that

@nickvergessen nickvergessen merged commit 835ee36 into master Mar 6, 2025
5 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/notify-on-broken-german-translation branch March 6, 2025 07:40
@rakekniven
Copy link
Member

Who is notified when something fails and how?

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 6, 2025

https://github.com/nextcloud/docker-ci/blob/master/translations/transifexSync.php#L148

for now.

Planing to distinct and post to repo in the future and then either ping the maintainer or the translation crew depending on the kind of the failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants