Skip to content

fix(translation): Notify on broken translations #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 6 commits into from
Mar 6, 2025
Merged

fix(translation): Notify on broken translations #730

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64c7ef7
fix(translation): Notify on broken German translations
nickvergessen Feb 24, 2025
e8ed337
fix(translation): Check other translation restrictions as well
nickvergessen Feb 25, 2025
77f2851
fix(translations): Also check unicode characters for now
nickvergessen Feb 25, 2025
1a54120
fix(translation): Check against triple dots
nickvergessen Feb 25, 2025
a061d6c
fix(translations): Check for leading or trailing whitespace in source
nickvergessen Feb 25, 2025
e6c6133
fix(translation): Move validation to a file, so users can check it lo…
nickvergessen Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(translations): Also check unicode characters for now 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Feb 25, 2025
commit 77f2851540ee369b7f5a4d34b5ccd6963e54efdf
6 changes: 6 additions & 0 deletions translations-app/handleAppTranslations.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ if [ $(jq '.translations | keys[]' l10n/en_GB.json | grep '|' | wc -l) -ne 0 ];
EXIT=4
fi

# Confirm English source does not contain the unicode single quote character
if [ $(jq '.translations | keys[]' l10n/en_GB.json | grep -E '(´|’)' | wc -l) -ne 0 ]; then
echo "English source contains unicode single quote character, that should be replaced by normal single quotes" 1>&2
EXIT=4
fi

for file in $(ls l10n/*.json)
do
# Make sure only RTL languages contain such characters
Expand Down