Skip to content

Conversation

@marceljd
Copy link
Contributor

Copy of the Redis part of #292 without the SMTP part. Redis has to be set at boot time, SMTP can be set through the Nextcloud webinterface. Tested with Apache / 14.0.3.

New PR after running update.sh

@rodrigoaguilera @unteem

@marceljd
Copy link
Contributor Author

#194

@J0WI
Copy link
Contributor

J0WI commented Dec 12, 2018

@J0WI J0WI mentioned this pull request Dec 12, 2018
@J0WI
Copy link
Contributor

J0WI commented Jan 5, 2019

@marceljd please also add memcache.distributed.

@marceljd
Copy link
Contributor Author

@J0WI done, unfortunately I did not have the old sources and did not succeed to commit on this PR. Git opened a new one #599

@J0WI
Copy link
Contributor

J0WI commented Jan 10, 2019

@marceljd the commits in #599 are quite messy.
Your sources are still available in your master. Can you manage to make your changes there?

@marceljd
Copy link
Contributor Author

marceljd commented Jan 10, 2019

@J0WI I tried to update the sources on my linux machine because the fork is already a few months old. After the commit I got an error and had to sign and force-commit, that is why the mess in 599 appeared. Would it be better to delete everything and make the changes to a fresh fork and PR? If I change the sources in my old fork there will be a lot of errors or not? Sry, not so experienced in Github way of working, try to learn fast...

@J0WI
Copy link
Contributor

J0WI commented Jan 10, 2019

You can use git rebase, but the branch in #599 is completely broken.
Here are some steps you can do:

  • Delete the redis branch from Added Redis memcache.distributed #599
  • checkout your own master
  • create a new branch from your master using git checkout -b branchname
  • checkout your own master again
  • reset your commits from master and pull from our master
  • rebase your new branchname, apply any updates, run update.sh and push to GitHub
  • create a new PR from branchname

@marceljd
Copy link
Contributor Author

marceljd commented Feb 7, 2019

closed via #600

@marceljd marceljd closed this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants