Skip to content

Use PHP 7.3 for NC 15 #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
J0WI merged 4 commits into from
Jan 14, 2019
Merged

Use PHP 7.3 for NC 15 #573

J0WI merged 4 commits into from
Jan 14, 2019

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented Dec 10, 2018

No description provided.

@J0WI J0WI requested review from tilosp and removed request for tilosp December 10, 2018 23:14
@J0WI
Copy link
Contributor Author

J0WI commented Dec 10, 2018

Blocked by php-memcached-dev/php-memcached#408

@J0WI J0WI mentioned this pull request Dec 10, 2018
Closed
tilosp
tilosp reviewed Dec 11, 2018
View reviewed changes
@J0WI
Copy link
Contributor Author

J0WI commented Dec 12, 2018

We could just drop memcached from the image in favor of #525 (comment)

@tilosp
Copy link
Member

tilosp commented Dec 12, 2018

We could just drop memcached from the image in favor of #525 (comment)

Yes dropping it should be fine. I don't think it is used that much, but we have no way of knowing for sure.

But we might want to wait a bit more before moving to php 7.3, because there are some apps that do not support it right now. (For example https://apps.nextcloud.com/apps/audioplayer/releases?platform=15#15)

@J0WI
Copy link
Contributor Author

J0WI commented Dec 12, 2018

Yes dropping it should be fine. I don't think it is used that much, but we have no way of knowing for sure.

Oh, there is one: nextcloud/survey_server#21

@J0WI
Copy link
Contributor Author

J0WI commented Dec 14, 2018

Oh, there is one: nextcloud/survey_server#21

@SnowMB could you help out here?

@J0WI J0WI force-pushed the php73 branch 3 times, most recently from 192b720 to 285f1cf Compare December 22, 2018 16:14
@J0WI
Copy link
Contributor Author

J0WI commented Dec 22, 2018

memcached-3.1.2 is PHP 7.3 compatible and Rello/audioplayer@ffba9fb adds compatibility to the audio player app.

@J0WI
Copy link
Contributor Author

J0WI commented Jan 5, 2019

Previous build failed because https://github.com/eduardok/libsmbclient-php/releases/tag/1.0.0 was not yet released.

@J0WI
Copy link
Contributor Author

J0WI commented Jan 11, 2019

Rebased

@J0WI
Copy link
Contributor Author

J0WI commented Jan 14, 2019

@tilosp do you think it's safe to ship this now? Otherwise I'll cherry-pick the pecl updates from here.

tilosp
tilosp approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@tilosp tilosp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should be fine now

@J0WI J0WI merged commit e8e3335 into nextcloud:master Jan 14, 2019
@J0WI J0WI deleted the php73 branch January 14, 2019 17:48
@J0WI J0WI mentioned this pull request Jan 16, 2019
Merged
@bestlibre
Copy link

bestlibre commented Jan 17, 2019 •
edited
Loading

the mail app is not yet compatible with 7.3 nextcloud/mail#1425

@tilosp tilosp mentioned this pull request Jan 17, 2019
Merged
@J0WI J0WI mentioned this pull request Apr 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tilosp tilosp tilosp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J0WI @tilosp @bestlibre