Add psalm pipeline #290
Merged
Add psalm pipeline #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
psalm-logger
branch
4 times, most recently
from
edf0efe to
7af1704
Compare
come-nc
requested changes
Apr 7, 2022
Contributor
|
If applicable try to use nextcloud/.github#53 |
come-nc
approved these changes
Apr 7, 2022
Contributor
|
phpunit.xml needs to go in tests/ |
There is still a few issues reported by psalm but this is mostly some usage of the private OC api and Sabre api. There is no way around that for now. This also port from ILogger to LoggerInterface Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
psalm-logger
branch
2 times, most recently
from
729adf0 to
b7e2f4f
Compare
come-nc
reviewed
Apr 7, 2022
CarlSchwan
force-pushed
the
psalm-logger
branch
2 times, most recently
from
c4243de to
85c90ca
Compare
Signed-off-by: Carl Schwan <[email protected]>
There is no integration tests, so no need for that file Signed-off-by: Carl Schwan <[email protected]>
guseit
reviewed
Apr 7, 2022
guseit
reviewed
Apr 7, 2022
guseit
reviewed
Apr 7, 2022
guseit
reviewed
Apr 7, 2022
Member
Author
|
/backport to stable23 |
backportbot-nextcloud
bot
added
the
backport-request
|
The backport to stable23 failed. Please do this backport manually. |
Member
Author
|
/backport to stable22 |
|
The backport to stable22 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a few issues reported by psalm but this is mainly some
usage of the private OC api and Sabre api. There is no way around that
for now.
This also port from ILogger to LoggerInterface