Move to new operation interface for Nextcloud 18 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
| * @since 18.0.0 | ||
| */ | ||
| public function isAvailableForScope(int $scope): bool { | ||
| return $scope === IManager::SCOPE_ADMIN; |
Member
There was a problem hiding this comment.
If we plan to have it for users, I could totally see this too.
Maybe people want to prevent anyone from downloading files with anything but the sync client (I do this for my financial data, blocking web ui and mobile clients)
Member
Author
There was a problem hiding this comment.
Sure, we could think about that in a later step, but that will require more work to not lock out other users who should still have access (like the share owner of a file)
16 tasks
8 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/noid/workflow-18
branch
from
01a7aa7 to
eb8b701
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
juliusknorr
force-pushed
the
enh/noid/workflow-18
branch
from
eb8b701 to
cedae76
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Member
|
I guess we merge this, as the transition is done and server API is fairly complete. And just shoot in PRs as they are needed, if any. Ok? |
Signed-off-by: Julius Härtl <[email protected]>
Member
|
Fine by me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.