Only cache the mimetype if the file exists #17332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
Contributor
rullzer
approved these changes
Sep 30, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
We should really get more tests for this code.
Member
Author
|
Yeah, seems like i @kesselb So maybe we need to modify that code block a bit more |
Member
Author
|
Well actually the code from b5f407e was removed by the rework of the workflow thing @juliushaertl |
Contributor
|
Hmm. I'm not sure if you can reproduce this issue on master. For now files_accesscontrol is not compatible with the new workflow: nextcloud/files_accesscontrol#132 |
blizzz
approved these changes
Sep 30, 2019
Member
|
For the new WFE the file info is set here: |
Member
|
/backport to stable17 |
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
rullzer
reviewed
Oct 8, 2019
nickvergessen
commented
Oct 8, 2019
Otherwise files access control will cache "application/octet-stream" for all the target node on: rename, move, copy and all other methods which create a new item To check this: 1. Add an automated tagging rule which tags on mimetype NOT "httpd/unix-directory" 2. Add an access control rule which checks for any mimetype 3. Create a folder and rename it, the folder should not be tagged, but it is Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/mimetype-changes-on-renaming-a-folder
branch
from
6290ebc to
d4d3725
Compare
nickvergessen
added
4. to release
|
backport to stable17 in #17538 |
|
backport to stable16 in #17539 |
|
backport to stable15 in #17540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise files access control will cache "application/octet-stream"
for all the target node on:
rename, move, copy and all other methods which create a new item
To check this:
Signed-off-by: Joas Schilling [email protected]