Make Operation work with IEntityCheck #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Signoff message is missing ;) |
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
fix/IEntityCheck
branch
from
e1c2c14 to
5461f3b
Compare
Member
Author
|
damnit. fixed :) |
juliusknorr
approved these changes
Dec 9, 2022
Member
|
I guess you would like to see this backported? |
Member
Author
|
/backport to stable25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ComplexOperation currently only calls RuleMatcher#setFileInfo (which then calls IFileCheck#setFileInfo), but IFileCheck inherits from IEntityCheck and people implementing a check would thus expect IEntityCheck#setEntitySubject to be called with a Node Object, which however is never called when the flow is triggered by this app, because this app doesn't call RuleMatcher#setEntitySubject. This PR fixes that.