reuse the cache entry we already have when doing rule checking #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested changes
Jul 10, 2023
icewind1991
force-pushed
the
check-reuse-cache-entry
branch
2 times, most recently
from
d468a29 to
4ef98e6
Compare
nickvergessen
requested changes
Jul 17, 2023
icewind1991
force-pushed
the
check-reuse-cache-entry
branch
2 times, most recently
from
96c6a3f to
6f4aee3
Compare
icewind1991
force-pushed
the
check-reuse-cache-entry
branch
from
6f4aee3 to
5ef9750
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
check-reuse-cache-entry
branch
from
5ef9750 to
a87fd4e
Compare
Member
Author
|
rebased and fixed |
Member
Author
|
started nextcloud/server#40478 to get a public API to make this easier for future versions |
nickvergessen
approved these changes
Sep 19, 2023
Member
|
/backport to stable27 |
Member
|
/backport to stable26 |
Member
|
/backport to stable25 |
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to re-quest the filecache for every item we have to check.
Fixes performance regression from #293