fixed the issue to accept 0 and null and changed the default text value to remaining downloads

[TSI-yogeshshejwadkar]

1. Fixed the issue to accept 0 and null
   Use case for null value - If I remove existing value from the text box, the download limit should get removed for that particular share.
   Use case for 0 value - If I put 0 or change the existing value to 0, then the download limit should get removed for that particular share.
2. Changed the default text value from total download count to remaining download count
3. Changed the hover text from Download limit: to Downloads:
4. Changed the implementation to allow to set the download limit to the file having allow resharing permissions

[come-nc]

Why is null needed? The same thing seems to be done for 0 or null, so it would be better if null was turned into 0 before calling the method.

[come-nc]

I am not sure this change makes sense, the label says download limit so it should show the limit, not something else.

[TSI-yogeshshejwadkar]

It makes sense because the remaining downloads is the current download limit. To show the initial download limit one week later to the customer does not deliver any new information to the user because he may remember the initial download limit or can calculate it with the download counter. It is more helpful to tell the user the current download limit to enable him to decide if he wants to increase it or not.

[come-nc]

Please run composer run cs:fix
And I am still not sold on the label text change. @jancborchardt any opinion on #69 (comment) ?

[jancborchardt]

@come-nc @TSI-yogeshshejwadkar what is the change – can I get before/after screenshots? Thanks! :)

[TSI-yogeshshejwadkar]

@come-nc @TSI-yogeshshejwadkar what is the change – can I get before/after screenshots? Thanks! :)

@jancborchardt

Here I set download limit to 5.

Here both the counters changed, the text is showing 4 (remaining count) and hover label is 1 (downloaded count) as I downloaded the file once.
Previously here the text was showing 5 (total count), and hover label was showing 1 (downloaded count) and this is the change.

[TSI-yogeshshejwadkar]

@come-nc @skjnldsv @jancborchardt @juliushaertl
Any update on this? Is it good to merge?

[come-nc]

If #77 is ruled as a yes then I am for merging this.
But there are conflicts with master.

[skjnldsv]

Please wait for #76 first too.
Also, there are changes we cannot accept here, let me add comments

[skjnldsv]

4. Changed the implementation to allow to set the download limit to the file having allow resharing permissions

Already handled by #79
You changes is unsecure and allows anyone