Skip to content

Show download count left #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 12, 2022
Merged

Show download count left #84

skjnldsv merged 1 commit into from
Apr 12, 2022

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 12, 2022 •
edited
Loading

Finishes #69

Capture d’écran_2022-04-12_11-47-09
Capture d’écran_2022-04-12_11-45-03

Fix #77

@skjnldsv
Show download count left
2faccd4 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv requested review from a team, Pytal, artonge, come-nc and szaimen and removed request for a team April 12, 2022 09:47
@skjnldsv skjnldsv self-assigned this Apr 12, 2022
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Apr 12, 2022
@come-nc
Copy link
Contributor

come-nc commented Apr 12, 2022

Does this replace #69 ? How does one remove the limit now? The idea of #69 was to accept 0/empty to remove the limit I think.

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 12, 2022

Does this replace #69 ? How does one remove the limit now? The idea of #69 was to accept 0/empty to remove the limit I think.

Already tackled by #82

@skjnldsv skjnldsv merged commit 6b4dac6 into master Apr 12, 2022
@skjnldsv skjnldsv deleted the feat/show-download-left branch April 12, 2022 13:33
@skjnldsv skjnldsv mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should we show the number of download left instead of the initial limit value?

3 participants

@skjnldsv @come-nc