Fix all the psalm issues and do php 7.4 cleanup #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Schwan <[email protected]>
skjnldsv
approved these changes
Apr 14, 2022
| * @return Response | ||
| */ | ||
| public function addRetention($tagid, $timeunit, $timeamount, $timeafter = Constants::CTIME) { | ||
| public function addRetention(string $tagid, int $timeunit, int $timeamount, int $timeafter = Constants::CTIME): Response { |
Member
|
Well well well... 7.4 cleanup was actually not allowed. The app still supported 22 and 23 which allow 7.3 Fix in #196 |
Member
|
Fail... looked at the wrong info.xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also port from OC/TimedJob to OCP/TimedJob