Skip to content

Migrate to vue #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 31 commits into from
Oct 18, 2022
Merged

Migrate to vue #196

nickvergessen merged 31 commits into from
Oct 18, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 8, 2022 •
edited
Loading

  • Add Vue bootstrap
  • Migrate the notifyBefore checkbox to a switch
  • Migrate the rules list
  • Migrate new rule form
  • Remove extra CSS file and add the style to the component in question
  • Remove handlebar fragments and tests
  • Ensure packaging works

Before

Bildschirmfoto vom 2022-08-08 21-24-40

After

Bildschirmfoto vom 2022-10-18 15-46-06

Fix #135

@nickvergessen nickvergessen self-assigned this Aug 8, 2022
@nickvergessen nickvergessen mentioned this pull request Aug 8, 2022
Merged
@nickvergessen nickvergessen force-pushed the feature/135/migrate-to-vue branch 3 times, most recently from 411c2a0 to d0c1535 Compare August 9, 2022 06:48
@nickvergessen
Add basic Vue setup
a9f664c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Ignore compiled js
a23207e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Migrate notifyBefore setting to Vue
62dddc1 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Move rendering, creation and deletion to Vue
c667b6c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Remove old code
d21f2b6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Don't try to render the compiled files
a4b2d52 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Change workflows
9784541 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix eslint and stylelint configs
fcd6ba6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add missing deps
3e54132 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix eslint and copyright
77bff49 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Clean package
364f171 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Remove unnessary span elements
d0f6fd5 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix unit tests
eaf6c9a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix php linting
8ed99ee 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add NPM to dependabot
bd791a6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
We don't use jQuery in here
d2ac2de 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Update packages
8ba9475 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Bump eslint config
6a8f613 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Bump again
1ee45c9 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix eslint
d44fc8f 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Bump all kind of packages
4daa5b7 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Migrate to @nextcloud/vue 7
64ae979 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Validate input fields
f59afb6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen marked this pull request as ready for review October 17, 2022 14:26
@nickvergessen nickvergessen force-pushed the feature/135/migrate-to-vue branch from c9b33c2 to f59afb6 Compare October 17, 2022 14:26
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 17, 2022

/backport to stable25

@nickvergessen
🤖 Less CI on pushes
1222059 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen mentioned this pull request Oct 18, 2022
Closed
24 tasks
@nickvergessen
🗨️ Adjust wordings
e8c220b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
↔️ Fix text alignments
b872461 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
🧹 Remove strange "Active: Yes" column
14771c6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
🧹 Remove "Actions" label
6480aae 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
🆙 Make button secondary
33f204e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
⏱️ Combine the amount and unit
6f67475 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix unlocking the checkbox again
9d21a6b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen mentioned this pull request Oct 18, 2022
Merged
@nickvergessen nickvergessen merged commit e5602ba into master Oct 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/135/migrate-to-vue branch October 18, 2022 14:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 18, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nickvergessen nickvergessen

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move to Vue and drop handlebars

2 participants

@nickvergessen