Allow per-groupfolder storage #3849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
per-groupfolder-storage
branch
8 times, most recently
from
642cb1c to
c3d0dc4
Compare
icewind1991
changed the title
icewind1991
force-pushed
the
per-groupfolder-storage
branch
4 times, most recently
from
6064534 to
6c99421
Compare
icewind1991
force-pushed
the
per-groupfolder-storage
branch
from
6c99421 to
3da6c9d
Compare
susnux
requested review from
a team and
nfebe
and removed request for
a team and
artonge
come-nc
requested changes
Jul 3, 2025
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
per-groupfolder-storage
branch
2 times, most recently
from
985d5ed to
35cc3a3
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
per-groupfolder-storage
branch
from
35cc3a3 to
bb5862e
Compare
come-nc
approved these changes
Jul 8, 2025
8 tasks
This was referenced Aug 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the assumption that all groupfolders are on the same storage. Instead we track the storage id and root id with the folder.
Currently all groupfolders will still be on the root storage, but this opens up the option to have them on different storages down the line.
Included is a cleanup of moving the folder data from an array to a proper type to make it fully clear which api return what fields.