-
Notifications
You must be signed in to change notification settings - Fork 19
fix: consume groupfolder properties as an array #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4eb1329 to
5defcb2
Compare
f85621f to
08d7f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are good 👍
Nextcloud master updated the php-http/guzzle7-adapter in nextcloud/server#53866
which included the changes in return type for php-fig/http-message. see: php-fig/http-message@1.1...2.0
@nabim777 Please update the description when relevant information
|
Need to fix another CI failure in this PR |
Signed-off-by: nabim777 <[email protected]>
4686b11 to
549b105
Compare
8d5153b to
247dead
Compare
Signed-off-by: Saw-jan <[email protected]>
we will look at them in next Pr once the CI is stable with this one |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
1. Support groupfolders master branch
The data structure to access the groupfolder has been changed in nextcloud/groupfolders#3849.
Implemented a method to convert the groupfolder entry into an array so that we maintain the compatibility with older versions.
2. Fix for unit test failre:
Nextcloud master updated the
php-http/guzzle7-adapterin nextcloud/server#53866which included the changes in return type for
php-fig/http-message. see: php-fig/http-message@1.1...2.0So, this PR fixes a php unit test failure in
OpenProjectControllerTest::testIsValidOpenProjectInstanceException, where the mockedResponseInterface::getBody()method was returning a string.According to Psr,
getBody()must return an instance ofPsr\Http\Message\StreamInterface. Returning a string was causing the following PHPUnit error:Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile