-
Notifications
You must be signed in to change notification settings - Fork 97
refactor(dav): readability improvements #4225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshtrichards
wants to merge
16
commits into
master
Choose a base branch
from
jtr/dav-small-refactors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+512
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daa3f5f to
4917721
Compare
Signed-off-by: Josh <[email protected]>
…rs, simplify code, and improve docs Improved readability and maintainability: added type hints, made error messages consistent, simplified code by removing unnecessary storage checks and redundant logic, clarified documentation, and aligned implementation with Nextcloud conventions. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
- Minor docblock imporvements - Extract mount path calculation to dedicated method Signed-off-by: Josh <[email protected]>
Added TODO comments to log silent edge cases Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Refactor user property to be readonly and initialize in constructor. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
And update variable names for clarity and consistency throughout. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
moved details to private method docblocks Signed-off-by: Josh <[email protected]>
4917721 to
a0c1dab
Compare
Signed-off-by: Josh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces less implementation changes than it may appear. Most of the diff is due to formatting changes, variable renaming, and factoring existing code into new private methods.
The overall goal:
Refactor code for better readability and future maintainability.
Key areas of change
Details by Component
RootCollection
PropFindPlugin
readonlyinitialize()for Sabre plugin consistencyMOUNT_POINT_PROPERTYNAMElogic into a private methodGroupFoldersHome
GroupFolderNode
ACLPlugin
Other:
TODO: