Skip to content

refactor(dav): readability improvements #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 16 commits into
base: master
Choose a base branch
from
+512 −233
Open

refactor(dav): readability improvements #4225

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bc89619
docs: Add docblock for GroupFolderNode class
joshtrichards Dec 16, 2025
fe0ec1a
refactor(dav): clean up GroupFoldersHome - add type hints, unify erro…
joshtrichards Dec 16, 2025
226d476
docs: docblock for getChildForPrincipal class
joshtrichards Dec 16, 2025
9ac4b85
refactor(dav): improve readability of PropFindPlugin
joshtrichards Dec 16, 2025
423bcc7
chore: Add TODOs for logging silent edge cases
joshtrichards Dec 17, 2025
0ad5a77
refactor(dav): Formatting and docs for ACLPlugin
joshtrichards Dec 17, 2025
e0c7a15
chore: set userFolder prop to readonly
joshtrichards Dec 17, 2025
32dd476
refactor(dav): make user readonly move to const in ACLPlugin
joshtrichards Dec 17, 2025
93e92e4
refactor(dav): ACLPlugin.php for improved readability
joshtrichards Dec 17, 2025
4a44b9e
refactor(dav): ACLPlugin variable naming
joshtrichards Dec 17, 2025
d3ef9db
refactor(dav): more ACLPlugin tidying for clarity (vars - WIP/fixup)
joshtrichards Dec 18, 2025
b718ba8
refactor(dav): Clarify ACL handling in ACLPlugin comments
joshtrichards Dec 19, 2025
cbfe5fd
refactor(dav): Move long callbacks to private methods for readability
joshtrichards Dec 19, 2025
6b76d84
refactor(DAV): var name + move pvts in GroupFoldersHome
joshtrichards Dec 19, 2025
a0c1dab
chore: enhance comments in ACLPlugin
joshtrichards Dec 24, 2025
7597263
fix: Update PHPDoc return type and parameter descriptions
joshtrichards Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(dav): Move long callbacks to private methods for readability 
Signed-off-by: Josh <[email protected]>
  • Loading branch information
@joshtrichards
joshtrichards committed Dec 24, 2025
commit cbfe5fd35fc592e5d59e699f9b4027840d9ba111
Loading