Add coverage to fix CI failure #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ok, one step further, now it's the oci one that is unhappy about composer deps issues ?! https://github.com/nextcloud/guests/pull/511/checks?check_run_id=1558104190 |
Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/noid/add-coverage-fix-ci
branch
from
7a00cf1 to
6a6c4a0
Compare
Member
Author
|
I've disabled coverage now as I saw it was explicitly disabled elsewhere and there is anyway no codecov setup so far. |
Aligned phpunit oci setup with the one from mysql. Removed phpunit version. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/noid/add-coverage-fix-ci
branch
from
bdf83ef to
346ddc1
Compare
juliusknorr
approved these changes
Dec 16, 2020
Member
|
/backport to stable-1.5 |
backportbot-nextcloud
bot
added
the
backport-request
|
The backport to stable-1.5 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this newly appeared issue: https://github.com/nextcloud/guests/pull/510/checks?check_run_id=1557739738
The change is taken from the mail app.