Skip to content

New occ command to create guest users #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 6 commits into from
Dec 18, 2020
Merged

New occ command to create guest users #510

PVince81 merged 6 commits into from
Dec 18, 2020

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 15, 2020

Create guest user with optional password without sending an email.

Fixes #505

@PVince81 PVince81 added enhancement New feature or request 3. to review Waiting for reviews labels Dec 15, 2020
@PVince81 PVince81 self-assigned this Dec 15, 2020
@PVince81 PVince81 mentioned this pull request Dec 15, 2020
Closed
@PVince81
Copy link
Member Author

PVince81 commented Dec 15, 2020 •
edited
Loading

  • remove output option
  • add ability to set password with argument ? (specifying env var is cumbersome from integration tests) never mind

@PVince81
Copy link
Member Author

PVince81 commented Dec 15, 2020 •
edited
Loading

  • add unit tests

@PVince81 PVince81 mentioned this pull request Dec 15, 2020
Merged
1 task
@PVince81
Copy link
Member Author

PVince81 commented Dec 15, 2020

attempt to fix CI here: #511

@PVince81
New occ command to create guest users
c62f13a 
Create guest user with optional password without sending an email.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the enh/505/occ-guests-add branch from 621906c to c62f13a Compare December 16, 2020 14:18
ChristophWurst
ChristophWurst reviewed Dec 16, 2020
View reviewed changes
nickvergessen
nickvergessen reviewed Dec 17, 2020
View reviewed changes
@PVince81 PVince81 merged commit bc0b2b5 into master Dec 18, 2020
@PVince81 PVince81 deleted the enh/505/occ-guests-add branch December 18, 2020 15:06
@wiswedel wiswedel mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@PVince81 PVince81

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ability to create guests with password directly

4 participants

@PVince81 @nickvergessen @ChristophWurst