Migrate the main mail store to Pinia #10138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GVodyanov
added
enhancement
2. developing
skill:frontend
GVodyanov
force-pushed
the
feat/migrate-main-store-pinia
branch
3 times, most recently
from
78247eb to
117f534
Compare
Contributor
Author
|
Not opening the PR yet as I still have the tests to migrate, but mail is useable (as far as it seems) |
Contributor
Author
|
Thanks so much for finishing the hardest parts Richard <3 |
GVodyanov
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
GVodyanov
requested review from
ChristophWurst and
hamza221
and removed request for
ChristophWurst,
GretaD and
kesselb
Contributor
|
needs a rebase, I wish you luck 🍀 |
kesselb
previously requested changes
Oct 10, 2024
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Should be merged after branch off for stable4.1
Member
|
Let's get this in |
st3iny
force-pushed
the
feat/migrate-main-store-pinia
branch
3 times, most recently
from
4325bfd to
1a5d97f
Compare
st3iny
approved these changes
Jan 7, 2025
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Rebased, fixed conflicts and did some testing. I couldn't spot breakage.
st3iny
force-pushed
the
feat/migrate-main-store-pinia
branch
from
1a5d97f to
37381d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Grigory Vodyanov <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]> # Conflicts: # src/components/ThreadEnvelope.vue # src/main.js # src/store/getters.js # src/store/index.js # src/store/mutations.js
GVodyanov
force-pushed
the
feat/migrate-main-store-pinia
branch
from
1157541 to
34d7ce8
Compare
Contributor
Author
|
Oh shoot I'm sorry I didn't see that you wanted to finish this too @st3iny. I hope I didn't step on your feet here, everything should work now though, if you could just give a final review. |
Member
|
No no, all good. I didn't do anything yet, just assigned myself to not forget about the PR. Thanks for the final rebase :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9237
This is going to be a big one...
Splitting stores into multiple files isn't very common in Pinia, but I really wanted to do so in this case, I took my inspiration for how to do it from these guys vuejs/pinia#802
A little overview of how this was done:
/storefor all the main mail store stuff[previous name]+Mutationdispatchandcommitusages in components to the correct Pinia usage