fix: migrate preferences to initial state #10585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
kesselb
approved these changes
Jan 20, 2025
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/preferences-initial-state
branch
from
a4edd73 to
0cfce5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10556
Regression from #10138
The preferences could not be parsed because they are overwritten when mounting the Vue app. Inspect the source of the index page and see that the preference elements are injected into the main container whose content is overwritten on mount. Hence, all values were lost and no preferences were actually loaded.
Before: Preferences are not parsed on the frontend due to missing elements.
After: Preferences are parsed correctly again.