-
Notifications
You must be signed in to change notification settings - Fork 294
Remember trusted senders #4103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember trusted senders #4103
Conversation
|
@jancborchardt on the ticket #505 you have written: But i guess you agree that if the person changes their mind then they should be able to undo the action, and hide images from a sender they marked as trusted to show images..? |
@GretaD yeah, that's why we also don't really need it. :) |
See https://support.google.com/mail/thread/12526769?hl=en and They both have it, and for a good reason. You can't otherwise undo this if you accidentally clicked the button. Not having this means we have to assume that users never make any mistakes and never revoke this. There could be someone who you formerly trust but then you maybe notice they send tracking pixels and you want to prevent them from invading your privacy. |
Yeah, thanks Christoph, I said i couldnt find it not that they dont have it. I agree that we should not have irreversible actions on our app. |
32fed10 to
2f2960e
Compare
1f35a29 to
be250bb
Compare
st3iny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just tested and it works well.
We should merge this and add an UI for revoking trust in a followup.
What about the PHP 7.2 lint though? Didn't we drop support for it?
That is the plan :) @GretaD did you open a ticket?
Yeah, I hoped so. But unfortunately the server doesn't compare the specified php version, so installations of Nextcloud 20 got the 1.6 release and that broke HTML messages. See #4150 for more details. |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the php7.2 linter happy
c32ec54 to
2019a1c
Compare
Signed-off-by: Christoph Wurst <[email protected]>
2019a1c to
87d99c0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hey @NESC1US I think there are a few misconceptions. Please look at the app again, like a current release. The button was there before. And even if you want to block all external resources generally, it's acceptable for some users to allow them. This PR is done, there's nothing to discuss from here. If you have a bug report or feature request then please open one as new ticket. And please stop by at https://nextcloud.com/contribute/code-of-conduct/. |

Fixes #505