Skip to content

Conversation

@ChristophWurst
Copy link
Member

Fixes #505

@GretaD
Copy link
Contributor

GretaD commented Nov 24, 2020

@jancborchardt on the ticket #505 you have written:
Clicking the button »Show images from this sender« should only be necessary once per sender.

But i guess you agree that if the person changes their mind then they should be able to undo the action, and hide images from a sender they marked as trusted to show images..?
In this case, how am I suppose to show this action (hide images) in the message? As a button, same as show images? Or do you have any better idea?
I checked Thunderbird and Gmail and i cannot find the option to hide the images after you click show.

@jancborchardt
Copy link
Member

I checked Thunderbird and Gmail and i cannot find the option to hide the images after you click show.

@GretaD yeah, that's why we also don't really need it. :)

@ChristophWurst
Copy link
Member Author

I checked Thunderbird and Gmail and i cannot find the option to hide the images after you click show.

See https://support.google.com/mail/thread/12526769?hl=en and

Bildschirmfoto von 2020-11-25 11-31-38

They both have it, and for a good reason. You can't otherwise undo this if you accidentally clicked the button. Not having this means we have to assume that users never make any mistakes and never revoke this. There could be someone who you formerly trust but then you maybe notice they send tracking pixels and you want to prevent them from invading your privacy.

@GretaD
Copy link
Contributor

GretaD commented Nov 25, 2020

I checked Thunderbird and Gmail and i cannot find the option to hide the images after you click show.

They both have it, and for a good reason. You can't otherwise undo this if you accidentally clicked the button. Not having this means we have to assume that users never make any mistakes and never revoke this. There could be someone who you formerly trust but then you maybe notice they send tracking pixels and you want to prevent them from invading your privacy.

Yeah, thanks Christoph, I said i couldnt find it not that they dont have it. I agree that we should not have irreversible actions on our app.

@GretaD GretaD force-pushed the feature/remember-trusted-senders branch from 32fed10 to 2f2960e Compare December 1, 2020 11:02
@GretaD GretaD marked this pull request as ready for review December 1, 2020 11:02
@GretaD GretaD requested review from StCyr and st3iny December 1, 2020 11:02
@GretaD GretaD force-pushed the feature/remember-trusted-senders branch 3 times, most recently from 1f35a29 to be250bb Compare December 2, 2020 12:27
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just tested and it works well.

We should merge this and add an UI for revoking trust in a followup.

What about the PHP 7.2 lint though? Didn't we drop support for it?

@ChristophWurst
Copy link
Member Author

We should merge this and add an UI for revoking trust in a followup.

That is the plan :) @GretaD did you open a ticket?

What about the PHP 7.2 lint though? Didn't we drop support for it?

Yeah, I hoped so. But unfortunately the server doesn't compare the specified php version, so installations of Nextcloud 20 got the 1.6 release and that broke HTML messages. See #4150 for more details.

Copy link
Member Author

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the php7.2 linter happy

@GretaD
Copy link
Contributor

GretaD commented Dec 2, 2020

We should merge this and add an UI for revoking trust in a followup.

That is the plan :) @GretaD did you open a ticket?

Here #4176, sorry i was suppose to open it yesterday :)

@GretaD GretaD force-pushed the feature/remember-trusted-senders branch 4 times, most recently from c32ec54 to 2019a1c Compare December 3, 2020 12:55
@GretaD GretaD force-pushed the feature/remember-trusted-senders branch from 2019a1c to 87d99c0 Compare December 3, 2020 12:58
@GretaD GretaD merged commit 783dc3c into master Dec 3, 2020
@GretaD GretaD deleted the feature/remember-trusted-senders branch December 3, 2020 13:03
@ghost

This comment has been minimized.

@st3iny

This comment has been minimized.

@ghost

This comment has been minimized.

@StCyr

This comment has been minimized.

@ghost

This comment has been minimized.

@ChristophWurst
Copy link
Member Author

Hey @NESC1US I think there are a few misconceptions. Please look at the app again, like a current release. The button was there before. And even if you want to block all external resources generally, it's acceptable for some users to allow them.

This PR is done, there's nothing to discuss from here. If you have a bug report or feature request then please open one as new ticket.

And please stop by at https://nextcloud.com/contribute/code-of-conduct/.

@nextcloud nextcloud locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remember »Show images from this sender«

6 participants